Feature/view state service architecture#19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a comprehensive JavaScript headless testing suite for the View, State, and Service engine, along with updates to documentation and configuration files to reflect recent architectural changes. The main focus is on enabling robust, platform-independent testing of JavaScript engine modules using Node.js, and ensuring that the .NET test suite can invoke these JavaScript tests as part of the regular test run.
Key changes:
JavaScript Headless Testing Infrastructure
Added a new
JsTestfolder with extensive headless unit tests for engine modules and REST model helpers, including a detailedREADME.mdexplaining test coverage, requirements, and usage. Tests cover a wide range of client-side logic, such as comment composer, selection, dashboard, workflow editor, and more. [1] [2] [3]Introduced
UnitTestJavaScript.csto the .NET test suite, which discovers and runs all JavaScript tests in theJsTestfolder using Node.js. The runner is platform-independent, checks for Node.js availability and version, and integrates results into the xUnit pipeline, skipping tests gracefully if prerequisites are missing.Configuration and Documentation Updates
Updated
webexpress.config.xmlto replace the legacy<limit>section with a<kestrel>section, aligning configuration with current server settings for connection and upload limits.Updated documentation in
tag.mdandtheme-selector.mdto reflect renaming of server-side controls fromControlRestTag/ControlRestSelectionThemetoControlDataTag/ControlDataSelectionTheme, ensuring consistency with the codebase. [1] [2] [3]